Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use moveToHelper from ign-rendering #825

Merged
merged 1 commit into from
May 26, 2021
Merged

Use moveToHelper from ign-rendering #825

merged 1 commit into from
May 26, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented May 19, 2021

🎉 Enhancement

Summary

I moved MoveToHelper class to ign-rendering, as part of the consolidation of the Scene3D. Releated to this PR gazebosim/gz-rendering#311

It requires a ign-rendering3 release.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@ahcorde ahcorde added enhancement New feature or request 🏰 citadel Ignition Citadel needs upstream release Blocked by a release of an upstream library labels May 19, 2021
@ahcorde ahcorde self-assigned this May 19, 2021
@ahcorde ahcorde requested a review from chapulina as a code owner May 19, 2021 09:53
@ahcorde ahcorde requested a review from iche033 May 19, 2021 09:54
@mjcarroll mjcarroll mentioned this pull request May 25, 2021
Merged
7 tasks
@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #825 (3e8a158) into ign-gazebo3 (3d4caa8) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 3e8a158 differs from pull request most recent head 0d7391d. Consider uploading reports for the commit 0d7391d to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           ign-gazebo3     #825   +/-   ##
============================================
  Coverage        77.85%   77.86%           
============================================
  Files              216      216           
  Lines            12150    12150           
============================================
+ Hits              9459     9460    +1     
+ Misses            2691     2690    -1
Impacted Files Coverage Δ
src/Server.cc 83.43% <0.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d4caa8...0d7391d. Read the comment docs.

@ahcorde
Copy link
Contributor Author

ahcorde commented May 26, 2021

@osrf-jenkins retest this please

2 similar comments
@ahcorde
Copy link
Contributor Author

ahcorde commented May 26, 2021

@osrf-jenkins retest this please

@ahcorde
Copy link
Contributor Author

ahcorde commented May 26, 2021

@osrf-jenkins retest this please

@ahcorde ahcorde enabled auto-merge (squash) May 26, 2021 20:26
@ahcorde ahcorde merged commit 0cacbd5 into ign-gazebo3 May 26, 2021
@ahcorde ahcorde deleted the ahcorde/movetohelper branch May 26, 2021 20:45
@ahcorde ahcorde mentioned this pull request May 26, 2021
Merged
8 tasks
@chapulina chapulina mentioned this pull request Jun 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@chapulina chapulina Awaiting requested review from chapulina

@iche033 iche033 Awaiting requested review from iche033

Assignees

@ahcorde ahcorde

Labels
🏰 citadel Ignition Citadel enhancement New feature or request needs upstream release Blocked by a release of an upstream library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahcorde @mjcarroll